Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed switch component styles #2928

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Fixed switch component styles #2928

merged 5 commits into from
Dec 4, 2024

Conversation

amoutens
Copy link
Contributor

@amoutens amoutens commented Dec 3, 2024 •
edited
Loading

Added loader when prop loading = true
image
Fixed disabled hover: hover doesn't appear when disabled
image

@amoutens amoutens self-assigned this Dec 3, 2024
@amoutens amoutens changed the title Fixed switch styles Fixed switch component styles Dec 3, 2024
@amoutens amoutens added bug Something isn't working Frontend part component design system task related to scss design system labels Dec 3, 2024
@amoutens amoutens linked an issue Dec 3, 2024 that may be closed by this pull request
(SP: 0.5) Fix Switch component styles #2927
Closed
Made1ra
Made1ra requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Made1ra Made1ra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is it necessary to use !important?
  2. Fix code formatting, please. We don't use semicolons ; at the end of statements in the project.
Screenshot 2024-12-03 at 19 49 22

@amoutens
Copy link
Contributor Author

amoutens commented Dec 3, 2024

  1. Is it necessary to use !important?
  2. Fix code formatting, please. We don't use semicolons ; at the end of statements in the project.
Screenshot 2024-12-03 at 19 49 22
  1. Is it necessary to use !important?
  2. Fix code formatting, please. We don't use semicolons ; at the end of statements in the project.
Screenshot 2024-12-03 at 19 49 22
  1. Is it necessary to use !important?
    Unfortunately, yes. Because in MUI there are more prioritized styles, like opacity or styles for disabled, and for this reason i use !important to override original styles
  2. I fixed this, thanks!

@amoutens amoutens requested a review from Made1ra December 3, 2024 19:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@amoutens amoutens merged commit baeeda5 into develop Dec 4, 2024
10 checks passed
@amoutens amoutens deleted the bugfix/2927/fix-switch-styles branch December 4, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebby2105 nebby2105 nebby2105 approved these changes

@SofiiaYevush SofiiaYevush SofiiaYevush approved these changes

@Made1ra Made1ra Made1ra approved these changes

@dudchakk dudchakk Awaiting requested review from dudchakk

@ShadowOfTheSpace ShadowOfTheSpace Awaiting requested review from ShadowOfTheSpace

@markgol777 markgol777 Awaiting requested review from markgol777

@Renatavl Renatavl Awaiting requested review from Renatavl

@Mav-Ivan Mav-Ivan Awaiting requested review from Mav-Ivan

@PavloButynets PavloButynets Awaiting requested review from PavloButynets

Assignees

@amoutens amoutens

Labels
bug Something isn't working component design system task related to scss design system Frontend part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 0.5) Fix Switch component styles
4 participants
@amoutens @Made1ra @SofiiaYevush @nebby2105